Comments on: R2P: A General-Purpose ReSharper Plugin http://blogs.jetbrains.com/dotnet/2013/01/r2p-a-general-purpose-resharper-plugin/ ReSharper for productivity, dotTrace for performance, dotCover for test coverage Sat, 18 May 2013 23:53:39 +0000 http://wordpress.org/?v=2.6.5 By: John Black http://blogs.jetbrains.com/dotnet/2013/01/r2p-a-general-purpose-resharper-plugin/#comment-445822 John Black Fri, 08 Mar 2013 07:42:46 +0000 http://blogs.jetbrains.com/dotnet/?p=4007#comment-445822 Implementing IDisposable with with Dispose(bool) is only required if the class has unmanaged fields. Otherwise it is considered an antipattern. Please see http://msmvps.com/blogs/peterritchie/archive/2013/01/20/the-dispose-pattern-as-an-anti-pattern.aspx Perhaps R2P (or R# in general) could intelligently check whether Dispose(bool) is required or not? Implementing IDisposable with with Dispose(bool) is only required if the class has unmanaged fields. Otherwise it is considered an antipattern. Please see
http://msmvps.com/blogs/peterritchie/archive/2013/01/20/the-dispose-pattern-as-an-anti-pattern.aspx

Perhaps R2P (or R# in general) could intelligently check whether Dispose(bool) is required or not?

]]> By: Dmitri Nesteruk http://blogs.jetbrains.com/dotnet/2013/01/r2p-a-general-purpose-resharper-plugin/#comment-433667 Dmitri Nesteruk Fri, 18 Jan 2013 15:46:52 +0000 http://blogs.jetbrains.com/dotnet/?p=4007#comment-433667 @Joe: no, the "move usings" feature is built in, and not configurable. The enum to class will not alter usages, the idea being that code should not really break. As a result, you may end up having some redundant casts that are fairly easy to detect and remove. @Joe: no, the “move usings” feature is built in, and not configurable. The enum to class will not alter usages, the idea being that code should not really break. As a result, you may end up having some redundant casts that are fairly easy to detect and remove.

]]> By: Joe White http://blogs.jetbrains.com/dotnet/2013/01/r2p-a-general-purpose-resharper-plugin/#comment-433534 Joe White Fri, 18 Jan 2013 14:14:46 +0000 http://blogs.jetbrains.com/dotnet/?p=4007#comment-433534 They've got a bunch of features that I wouldn't want in the way (like "move usings into namespace", which I don't want, and which most everybody gets wrong anyway by forgetting to add "global::"). Does anyone know whether you can disable the features you don't want cluttering up your context menus? And whether you can share those "what's-disabled" lists in the .DotSettings team-shared file? "Enum to Class" definitely looks interesting, though. That's a painful refactoring, especially if you have code that casts those enums to ints to store them in the database. Can R2P turn those casts into some corresponding OO code? If so, then that alone would be well worth the price of admission. They’ve got a bunch of features that I wouldn’t want in the way (like “move usings into namespace”, which I don’t want, and which most everybody gets wrong anyway by forgetting to add “global::”). Does anyone know whether you can disable the features you don’t want cluttering up your context menus? And whether you can share those “what’s-disabled” lists in the .DotSettings team-shared file?

“Enum to Class” definitely looks interesting, though. That’s a painful refactoring, especially if you have code that casts those enums to ints to store them in the database. Can R2P turn those casts into some corresponding OO code? If so, then that alone would be well worth the price of admission.

]]> By: Dmitri Nesteruk http://blogs.jetbrains.com/dotnet/2013/01/r2p-a-general-purpose-resharper-plugin/#comment-431282 Dmitri Nesteruk Wed, 16 Jan 2013 13:28:37 +0000 http://blogs.jetbrains.com/dotnet/?p=4007#comment-431282 @Patrick: you're absolutely right. In fact, when the GoF were interviewed recently and asked what patterns they'd change, they said none except maybe remove Singleton. The accepted practice in .NET circles is to have single-instance lifetimes managed by an IoC container. @Patrick: you’re absolutely right. In fact, when the GoF were interviewed recently and asked what patterns they’d change, they said none except maybe remove Singleton. The accepted practice in .NET circles is to have single-instance lifetimes managed by an IoC container.

]]> By: Patrick Smacchia http://blogs.jetbrains.com/dotnet/2013/01/r2p-a-general-purpose-resharper-plugin/#comment-431281 Patrick Smacchia Wed, 16 Jan 2013 13:25:44 +0000 http://blogs.jetbrains.com/dotnet/?p=4007#comment-431281 Very interesting, still, I dislike Make Singleton. 99% of Singleton usage are code smell that prevents code to be tested properly. http://codebetter.com/patricksmacchia/2009/11/16/back-to-basics-usage-of-static/ Very interesting, still, I dislike Make Singleton. 99% of Singleton usage are code smell that prevents code to be tested properly. http://codebetter.com/patricksmacchia/2009/11/16/back-to-basics-usage-of-static/

]]>